1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.
use std::borrow::Cow;
use std::collections::HashMap;
use std::sync::Arc;
use async_trait::async_trait;
use datafusion::catalog::{Session, TableProvider, TableProviderFactory};
use datafusion::error::Result as DFResult;
use datafusion::logical_expr::CreateExternalTable;
use datafusion::sql::TableReference;
use iceberg::arrow::schema_to_arrow_schema;
use iceberg::io::FileIO;
use iceberg::table::StaticTable;
use iceberg::{Error, ErrorKind, Result, TableIdent};
use super::IcebergTableProvider;
use crate::to_datafusion_error;
/// A factory that implements DataFusion's `TableProviderFactory` to create `IcebergTableProvider` instances.
///
/// # Example
///
/// The following example demonstrates how to create an Iceberg external table using SQL in
/// a DataFusion session with `IcebergTableProviderFactory`:
///
/// ```
/// use std::sync::Arc;
///
/// use datafusion::execution::session_state::SessionStateBuilder;
/// use datafusion::prelude::*;
/// use datafusion::sql::TableReference;
/// use iceberg_datafusion::IcebergTableProviderFactory;
///
/// #[tokio::main]
/// async fn main() {
/// // Create a new session context
/// let mut state = SessionStateBuilder::new().with_default_features().build();
///
/// // Register the IcebergTableProviderFactory in the session
/// state.table_factories_mut().insert(
/// "ICEBERG".to_string(),
/// Arc::new(IcebergTableProviderFactory::new()),
/// );
///
/// let ctx = SessionContext::new_with_state(state);
///
/// // Define the table reference and the location of the Iceberg metadata file
/// let table_ref = TableReference::bare("my_iceberg_table");
/// // /path/to/iceberg/metadata
/// let metadata_file_path = format!(
/// "{}/testdata/table_metadata/{}",
/// env!("CARGO_MANIFEST_DIR"),
/// "TableMetadataV2.json"
/// );
///
/// // SQL command to create the Iceberg external table
/// let sql = format!(
/// "CREATE EXTERNAL TABLE {} STORED AS ICEBERG LOCATION '{}'",
/// table_ref, metadata_file_path
/// );
///
/// // Execute the SQL to create the external table
/// ctx.sql(&sql).await.expect("Failed to create table");
///
/// // Verify the table was created by retrieving the table provider
/// let table_provider = ctx
/// .table_provider(table_ref)
/// .await
/// .expect("Table not found");
///
/// println!("Iceberg external table created successfully.");
/// }
/// ```
///
/// # Note
/// This factory is designed to work with the DataFusion query engine,
/// specifically for handling Iceberg tables in external table commands.
/// Currently, this implementation supports only reading Iceberg tables, with
/// the creation of new tables not yet available.
///
/// # Errors
/// An error will be returned if any unsupported feature, such as partition columns,
/// order expressions, constraints, or column defaults, is detected in the table creation command.
#[derive(Debug, Default)]
pub struct IcebergTableProviderFactory {}
impl IcebergTableProviderFactory {
pub fn new() -> Self {
Self {}
}
}
#[async_trait]
impl TableProviderFactory for IcebergTableProviderFactory {
async fn create(
&self,
_state: &dyn Session,
cmd: &CreateExternalTable,
) -> DFResult<Arc<dyn TableProvider>> {
check_cmd(cmd).map_err(to_datafusion_error)?;
let table_name = &cmd.name;
let metadata_file_path = &cmd.location;
let options = &cmd.options;
let table_name_with_ns = complement_namespace_if_necessary(table_name);
let table = create_static_table(table_name_with_ns, metadata_file_path, options)
.await
.map_err(to_datafusion_error)?
.into_table();
let schema = schema_to_arrow_schema(table.metadata().current_schema())
.map_err(to_datafusion_error)?;
Ok(Arc::new(IcebergTableProvider::new(table, Arc::new(schema))))
}
}
fn check_cmd(cmd: &CreateExternalTable) -> Result<()> {
let CreateExternalTable {
schema,
table_partition_cols,
order_exprs,
constraints,
column_defaults,
..
} = cmd;
// Check if any of the fields violate the constraints in a single condition
let is_invalid = !schema.fields().is_empty()
|| !table_partition_cols.is_empty()
|| !order_exprs.is_empty()
|| !constraints.is_empty()
|| !column_defaults.is_empty();
if is_invalid {
return Err(Error::new(ErrorKind::FeatureUnsupported, "Currently we only support reading existing icebergs tables in external table command. To create new table, please use catalog provider."));
}
Ok(())
}
/// Complements the namespace of a table name if necessary.
///
/// # Note
/// If the table name is a bare name, it will be complemented with the 'default' namespace.
/// Otherwise, it will be returned as is. Because Iceberg tables are always namespaced, but DataFusion
/// external table commands maybe not include the namespace, this function ensures that the namespace is always present.
///
/// # See also
/// - [`iceberg::NamespaceIdent`]
/// - [`datafusion::sql::planner::SqlToRel::external_table_to_plan`]
fn complement_namespace_if_necessary(table_name: &TableReference) -> Cow<'_, TableReference> {
match table_name {
TableReference::Bare { table } => {
Cow::Owned(TableReference::partial("default", table.as_ref()))
}
other => Cow::Borrowed(other),
}
}
async fn create_static_table(
table_name: Cow<'_, TableReference>,
metadata_file_path: &str,
props: &HashMap<String, String>,
) -> Result<StaticTable> {
let table_ident = TableIdent::from_strs(table_name.to_vec())?;
let file_io = FileIO::from_path(metadata_file_path)?
.with_props(props)
.build()?;
StaticTable::from_metadata_file(metadata_file_path, table_ident, file_io).await
}
#[cfg(test)]
mod tests {
use datafusion::arrow::datatypes::{DataType, Field, Schema};
use datafusion::catalog::TableProviderFactory;
use datafusion::common::{Constraints, DFSchema};
use datafusion::execution::session_state::SessionStateBuilder;
use datafusion::logical_expr::CreateExternalTable;
use datafusion::parquet::arrow::PARQUET_FIELD_ID_META_KEY;
use datafusion::prelude::SessionContext;
use datafusion::sql::TableReference;
use super::*;
fn table_metadata_v2_schema() -> Schema {
Schema::new(vec![
Field::new("x", DataType::Int64, false).with_metadata(HashMap::from([(
PARQUET_FIELD_ID_META_KEY.to_string(),
"1".to_string(),
)])),
Field::new("y", DataType::Int64, false).with_metadata(HashMap::from([(
PARQUET_FIELD_ID_META_KEY.to_string(),
"2".to_string(),
)])),
Field::new("z", DataType::Int64, false).with_metadata(HashMap::from([(
PARQUET_FIELD_ID_META_KEY.to_string(),
"3".to_string(),
)])),
])
}
fn table_metadata_location() -> String {
format!(
"{}/testdata/table_metadata/{}",
env!("CARGO_MANIFEST_DIR"),
"TableMetadataV2.json"
)
}
fn create_external_table_cmd() -> CreateExternalTable {
let metadata_file_path = table_metadata_location();
CreateExternalTable {
name: TableReference::partial("static_ns", "static_table"),
location: metadata_file_path,
schema: Arc::new(DFSchema::empty()),
file_type: "iceberg".to_string(),
options: Default::default(),
table_partition_cols: Default::default(),
order_exprs: Default::default(),
constraints: Constraints::empty(),
column_defaults: Default::default(),
if_not_exists: Default::default(),
temporary: false,
definition: Default::default(),
unbounded: Default::default(),
}
}
#[tokio::test]
async fn test_schema_of_created_table() {
let factory = IcebergTableProviderFactory::new();
let state = SessionStateBuilder::new().build();
let cmd = create_external_table_cmd();
let table_provider = factory
.create(&state, &cmd)
.await
.expect("create table failed");
let expected_schema = table_metadata_v2_schema();
let actual_schema = table_provider.schema();
assert_eq!(actual_schema.as_ref(), &expected_schema);
}
#[tokio::test]
async fn test_schema_of_created_external_table_sql() {
let mut state = SessionStateBuilder::new().with_default_features().build();
state.table_factories_mut().insert(
"ICEBERG".to_string(),
Arc::new(IcebergTableProviderFactory::new()),
);
let ctx = SessionContext::new_with_state(state);
// All external tables in DataFusion use bare names.
// See https://github.com/apache/datafusion/blob/main/datafusion/sql/src/statement.rs#L1038-#L1039
let table_ref = TableReference::bare("static_table");
// Create the external table
let sql = format!(
"CREATE EXTERNAL TABLE {} STORED AS ICEBERG LOCATION '{}'",
table_ref,
table_metadata_location()
);
let _df = ctx.sql(&sql).await.expect("create table failed");
// Get the created external table
let table_provider = ctx
.table_provider(table_ref)
.await
.expect("table not found");
// Check the schema of the created table
let expected_schema = table_metadata_v2_schema();
let actual_schema = table_provider.schema();
assert_eq!(actual_schema.as_ref(), &expected_schema);
}
}